Comfy-Org / Comfy-Org/ComfyUI_frontend

[DevTask] Structure selection data type

Open
#4,743 0 comments 0 reactions 1 assignee Claimed by @huchenlei View on GitHub
area:litegraph developer experience perf:speed
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

The data type passed to `onSelectionChange` is too abstrast, requiring costly runtime type checks by subscribers like frontend selection toolbar. The data type can be made a struct that organizes into LGraphNode, LGraphGroup, RerouteNode, etc.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4743-DevTask-Structure-selection-data-type-2476d73d36508145a210d8a812890541) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.