Comfy-Org / Comfy-Org/ComfyUI_frontend

[DevTask] Investigate node.widgets_values set as object

Open
#4,733 0 comments 0 reactions 0 assignees View on GitHub
developer experience
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

At least one extension is using an object in place of an array for `widget_values`:

https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/blob/4c7858ddd5126f7293dc3c9f6e0fc4c263cde079/web/js/VHS.core.js#L31-L159

This causes repeat issues, as the actual types defined in the core code are invalid. All tests and expectations are nominal - until the code reaches consumers, where the extensions are loaded, and things break - cannot use app at all in some instances.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4733-DevTask-Investigate-node-widgets_values-set-as-object-2476d73d365081a88b1ad461be6e5c3d) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.