Comfy-Org / Comfy-Org/ComfyUI_frontend

[DevTask] Fix scroll zoom - wheel events

Open
#4,731 0 comments 0 reactions 1 assignee Claimed by @jtydhr88 View on GitHub
area:navigation
Dominant language
TypeScript
Stars
2k
Forks
702
Avg merge
1d 8h
Merged PRs (30d)
512

Description

Current handler attempts to use the long-deprecated `wheelDeltaY` property, and (hopefully always) falls back to the `detail` property of the event.

This should be replaced with `deltaY`, and add code to account for the [mode](https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaMode).

This should resolve the immense discrepancies between zoom speeds on various pointer devices.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4731-DevTask-Fix-scroll-zoom-wheel-events-2476d73d3650817ea142e4679033ff86) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.