Comfy-Org / Comfy-Org/ComfyUI_frontend

[DevTask] Revisit ESLint rules after TS strict mode enabled

Open
#4,730 0 comments 1 reaction 0 assignees View on GitHub
developer experience
Dominant language
TypeScript
Stars
2k
Forks
702
Avg merge
1d 8h
Merged PRs (30d)
512

Description

Disabled rules in ESLint config should be reviewed after strict mode has been enabled.

e.g. re-enable:
```
"@typescript-eslint/no-unnecessary-type-assertion": "off",
```

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4730-DevTask-Revisit-ESLint-rules-after-TS-strict-mode-enabled-2476d73d3650812f8727e126c3710ff9) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Research direction

Start by locating the ESLint configuration and identifying rules disabled after TypeScript strict mode was enabled. Review the example rule, @typescript-eslint/no-unnecessary-type-assertion, along with the other disabled rules, then use the existing lint check to verify which can be enabled without violations. Done means the relevant rules are re-enabled and lint passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.