Comfy-Org / Comfy-Org/ComfyUI_frontend

[DevTask] The ContextMenu originating event is currently optional

Open
#4,726 0 comments 0 reactions 0 assignees View on GitHub
developer experience
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

Some extensions are not providing the `event` option to the ContextMenu. This is technically optional, but should be required to spawn the context menu. As we want to be able to Spawn ContextMenu without a amouse event (e.g. keyboard), using MouseEvent as the type should also be replaced with an interface for the actual params (e.g. spawn location, parent element).

This may need to wait until Litegraph context menus are replaced.

- Ref: rgthree https://github.com/Comfy-Org/litegraph.js/pull/728

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4726-DevTask-The-ContextMenu-originating-event-is-currently-optional-2476d73d3650814ab3b6d437aeeb7673) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.