Comfy-Org / Comfy-Org/ComfyUI_frontend
[DevTask] Type disparity between SlotShape vs RenderShape
Open
developer experience
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
Comfy-Org/litegraph.js#154 added SlotShape as a subset of RenderShape, however this has not been changed in the serialisation interface. Type assertions are required to make this work, removing type-safety.
Interfaces and supporting code need to be updated to reflect actual usage.
┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4714-DevTask-Type-disparity-between-SlotShape-vs-RenderShape-2476d73d365081a58481eb419fc6efca) by [Unito](https://www.unito.io)
Contributor guide
Assessment
This issue has not been assessed yet.