Comfy-Org / Comfy-Org/ComfyUI_frontend

[question] Should we use this package imports in a web extension?

Open
#4,703 7 comments 0 reactions 0 assignees View on GitHub
developer experience question
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

Hey,

I'm migrating fully to ts and in the process I'm taking advantage of the org published packages!
Very neat as it removed a bunch of custom types I was managing but I'm not 100% sure to get how to consume imports in this case (both the globals like `app` and the lt stuff).

The frontend-types suggest using `@/scripts/app` (is that really a thing we can do even in blank js extensions?) but I couldn't find how to make TS happy about that (neither the ` import { app } from '../../scripts/app.js'` that I currently use in the plain js exts)

Image

---

## TLDR
**when using ts or a bundler, how should we manage imports to LiteGraph and comfy globals?**

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4703-question-Should-we-use-this-package-imports-in-a-web-extension-2476d73d36508118ac0cf98d46e1216a) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.