Comfy-Org / Comfy-Org/ComfyUI_frontend

Add edge case handling to ExecutableNodeDTO

Open
#4,700 0 comments 0 reactions 0 assignees View on GitHub
area:subgraph
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

Comfy-Org/litegraph.js#1102 addresses most of the edge cases (in particular, KJ get/set nodes) where the new execution flattening for subgraphs breaks existing extensions.

However, the original design of this was targeted specifically for subgraphs and does not address all edge cases. The logic here should be extended to account for situations where:

- Node does not have a normal input for the requested link slot
- `getInputLink` (or override) returns a falsy value

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4700-Add-edge-case-handling-to-ExecutableNodeDTO-2476d73d365081dabe6ac56c2173cfc1) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.