Comfy-Org / Comfy-Org/ComfyUI_frontend

CONNECTING_LINK_COLOR, only one of two options

Open
#4,694 0 comments 1 reaction 0 assignees View on GitHub
area:links
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

First I have to say, fantastic work on your version of litegraph!

Are there any plans to modify the CONNECTING_LINK_COLOR to match the link_type_colors if set? Currently it's only picking from either orange or green based on if it's an event or connecting link.

I'd be happy to suggest something on a pull request, but wanted to check first if this was planned / wanted. If not I'm happy to close the issue and monkey patch on my version.

`const colour = connType === LiteGraph.EVENT
? LiteGraph.EVENT_LINK_COLOR
: LiteGraph.CONNECTING_LINK_COLOR`

[Link to code found in LGraphCanvas](https://github.com/Comfy-Org/litegraph.js/blob/2408f2446c698fb0f32edbcb11541268ec5850d8/src/LGraphCanvas.ts#L4244C52-L4244C53)

Example of connecting color differing from link type color :
Image

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4694-CONNECTING_LINK_COLOR-only-one-of-two-options-2476d73d365081e1b43dc65d7baa4908) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.