Comfy-Org / Comfy-Org/ComfyUI_frontend

`positionSelectionOverlay` is called every frame while dragging, zooming, panning

Open
#4,631 1 comment 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

This is really inefficient if the element is positioned via DOM.

https://github.com/Comfy-Org/ComfyUI_frontend/blob/aabea4b78dcd258086f5c9c1fb008cf0683808f1/src/components/graph/SelectionOverlay.vue#L60

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4631-selectionChanged-is-changed-every-frame-while-dragging-zooming-panning-2416d73d3650819fbe43fcb4da3cfaba) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.