Comfy-Org / Comfy-Org/ComfyUI_frontend

[Bug]: Node Badges and Group Controls Overlapping

Open
#4,110 0 comments 0 reactions 0 assignees View on GitHub
area:nodes enhancement
Dominant language
TypeScript
Stars
2k
Forks
702
Avg merge
1d 8h
Merged PRs (30d)
512

Description

### Custom Node Testing

- [x] I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help)

### Frontend Version

v1.21.7

### Expected Behavior

The group and/or node would give enough margin/padding to ensure that the text of the badge would not overlap with the group's controls. See example on the left. Looks nice!

![Image](https://github.com/user-attachments/assets/1c8a94f5-6425-414a-a27f-b7b423ece91a)

### Actual Behavior

When you have **Node source badge mode** as enabled and are using node that has a badge displayed and that node is the most top-right element of a newly created group, the node's badge text and the group controls overlap and conflict.

![Image](https://github.com/user-attachments/assets/52b9d038-ffa3-4c55-8af0-a17ed5589a73)

### Steps to Reproduce

Steps to reproduce:

1. In settings enable "Node source badge mode" to Show All (or Hide Built-in and use a custom node)
2. Place a node with a badge on the canvas
3. Create a group around that node

It can get really ugly really fast (especially if you have a long Group Name), as shown here:

![Image](https://github.com/user-attachments/assets/250faac8-0fcf-4d76-a0de-be9073dd8415)

### Debug Logs

```powershell
N/A
```

### Browser Logs

N/A

### Setting JSON

N/A

### What browsers do you use to access the UI ?

Mozilla Firefox

### Other Information

N/A

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-4110-Bug-Node-Badges-and-Group-Controls-Overlapping-20c6d73d36508145a9a5d568afe34954) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Research direction

Reproduce the overlap in the frontend with Node source badge mode set to Show All, then inspect the group controls, node badge, and group layout rendering involved in the canvas UI. Confirm the fix by repeating the reported steps with a long group name and verify that badge text and group controls no longer overlap.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.