Comfy-Org / Comfy-Org/ComfyUI_frontend

[Bug]: Renamed widgets are not

Open
#3,654 11 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Frontend Version

**Comfy 0.3.30
Front end 1.17.11**

### Expected Behavior

If you right click an input you can rename the slot. For non-widget inputs, this change is displayed on the node.

If you right-click a widget (whether or not it is connected) you can rename it. I would expect the new name to be displayed, as it is for an input.

### Actual Behavior

A renamed widget does not have the name displayed.

![Image](https://github.com/user-attachments/assets/1ed04ab4-f822-4924-8f23-8c26cdd681da)

### Steps to Reproduce

For any widget:
- right click the input dot
- select `Rename Slot`
- type a new name
- see that it isn't displayed

### Debug Logs

```powershell
Nothing relevant
```

### Browser Logs

Niothing relevant

### Setting JSON

[comfy.settings.json](https://github.com/user-attachments/files/19927653/comfy.settings.json)

### What browsers do you use to access the UI ?

Brave

### Other Information

Looking at the javascript console, it appears that editing the name of the slot sets the `label` attribute of the input (in `node.inputs`) but doesn't change the `label` attribute of the widget (in `node.widgets`). If the label attribute is changed manually in the console, the label displayed updates. The widget label is what gets displayed.

**Proposed solution:**

When `input.label` is set, `input.widget.label` should also be set, if `input.widget` is defined.

**Additional suggestion:**

When `Rename Slot` is selected, if the label is undefined, the dialog box starts empty. It would be more intuitive if it were populated with the value of `localised_name`, since this is the currently displayed value that is going to be replaced.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-3654-Bug-Renamed-widgets-are-not-1e26d73d365081938374e185a99af5cf) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.