Comfy-Org / Comfy-Org/ComfyUI_frontend
[Bug] protential performance issue for 3d nodes
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
2025/06/05 update
The following issue already got fixed by https://github.com/Comfy-Org/ComfyUI_frontend/pull/3961, but still having the issue of a large number of load3d node, so keep this issue opening for now
> Currently, when we remove 3D nodes from the workflow, their corresponding two WebGLRenderers are not released simultaneously. This can lead to potential issues, such as when repeatedly adding and removing 3D nodes up to a certain number of times, even if there is only one 3D node in the workflow, the browser will trigger an error indicating that it has reached the Context limit.
>
> Test case
> 1. In a workflow without any 3D nodes, the browser's current WebGLRenderer count is 0
> 
> 2. After adding one 3D node, the browser's current WebGLRenderer count becomes 2 (which is reasonable, as one is used for rendering the main scene and one for the preview view).
> 
> 3. However, when the node is removed, the WebGLRenderer count remains at 2, indicating they have not been properly released.
> 
> 4. Additionally, it can be observed that the scene is not cleaned up completely. There are still some objects that remain uncleaned, which also needs to be addressed.
>
> 
>
> ┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-3333-Bug-protential-performance-issue-for-3d-nodes-1cd6d73d365081fdb9a0e126ff6445d6) by [Unito](https://www.unito.io)
Contributor guide
Assessment
This issue has not been assessed yet.