Comfy-Org / Comfy-Org/ComfyUI_frontend
[DevTask]: Run browser tests on Windows runner
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
### Is there an existing issue for this?
- [x] I have searched the existing issues and checked the recent builds/commits
### What would your feature do ?
When developer uses Unix, and CI tests also all use Unix, changes are never tested on Windows. Running browser tests on Windows container during CI tests would resolve this lack of coverage.
### Proposed workflow
1. The workflows from comfyanonymous/ComfyUI or Comfy-Org/desktop are used to setup ComfyUI server in Windows container
2. The `chromium` Playwright project is run in the Windows runner
### Additional information
Issues that could potentially have been caught if a Playwright tests were run on Windows runner:
- https://github.com/comfyanonymous/ComfyUI/pull/4801
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2797
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/3196
- https://github.com/Comfy-Org/ComfyUI_frontend/pull/2630
- https://github.com/comfyanonymous/ComfyUI/pull/4906 (maybe)
┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-3197-DevTask-Run-browser-tests-on-Windows-runner-1bf6d73d36508137b52bc6f8e668fb68) by [Unito](https://www.unito.io)
Contributor guide
Assessment
This issue has not been assessed yet.