Comfy-Org / Comfy-Org/ComfyUI_frontend

[Bug]: Queue button stuck on `Shift` state after `Shift`+`RMB` click in Firefox

Open
#2,426 0 comments 0 reactions 0 assignees View on GitHub
browser:firefox verified bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Frontend Version

https://github.com/Comfy-Org/ComfyUI_frontend/commit/628facaa75ad110566bebe7c5a5209cbb34de8f8

### Expected Behavior

Queue button should revert back to normal after `Shift` key is released

### Actual Behavior

When performing a `RMB` click while holding `Shift` in Firefox (which the purpose of is to override the browser's context menu being overridden), and then releasing `Shift` before closing the context menu, it causes the queue button to be stuck in the `Shift` state (where the action is `Queue workflow to front`).

The below animation shows a normal `RMB` click, `Shift` + `RMB` (releasing `Shift` before closing the context menu), and then a single tap of the `Shift` key to fix the queue button's state.

![Image](https://github.com/user-attachments/assets/b0bf3f6a-2f9a-4ba1-a92b-eb8ac0660e17)

### Steps to Reproduce

`Shift` + `RMB` click on any part of the UI.

### Debug Logs

```powershell
n/a
```

### Browser Logs

n/a

### Setting JSON

n/a

### What browsers do you use to access the UI ?

Mozilla Firefox

### Other

_No response_

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-2426-Bug-Queue-button-stuck-on-Shift-state-after-Shift-RMB-click-in-Firefox-1916d73d365081ca9d21f248b945b64a) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.