Comfy-Org / Comfy-Org/ComfyUI_frontend

[Bug]: When using a different language (non-English) in the system, Keybinding does not work

Open
#2,340 4 comments 0 reactions 0 assignees View on GitHub
verified bug
Dominant language
TypeScript
Stars
2k
Forks
702
Avg merge
1d 8h
Merged PRs (30d)
512

Description

### Frontend Version

ComfyUI_frontend v1.8.5

### Expected Behavior

When using different language (not English) in the system, any key combinations set in the settings should work. It should not be that CTRL+S does not work when using a different language set in the system.
I expect that the CTRL+S I set up will always work, in any locales and system languages ​​(in any keyboard layout).

### Actual Behavior

When using a different language (non-English) in the system, Keybinding does not work.
More precisely, ONLY those keybindings that are set in the current language start to work.

### Steps to Reproduce

1) Switch the system keyboard layout to Russian.
2) Try using the hotkey CTRL+S, which was set in the Keybindings settings.

### What browsers do you use to access the UI ?

Google Chrome

### Other

I assume this is an intentional change?

However, I really wish this behavior could be disabled, as I often switch between two languages ​​in the system, which is why keybindings simply do not work if they are set in another language.

Also, if this innovation is left as is, it would be very useful to add in this case the ability to add multiple hotkeys for one action.
For example, if I used the "Save Workflow" function, I would set two hotkeys for different locales (English and Russian):
CTRL+S; CTRL+Ы

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-2340-Bug-When-using-a-different-language-non-English-in-the-system-Keybinding-does-no-1856d73d3650818b865febf11a04e5a0) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in Chrome with the system keyboard layout switched to Russian, using the configured CTRL+S keybinding. Locate the frontend keybinding handling from the settings behavior and compare input under English and Russian layouts. Done means configured keybindings work across locales, or the supported behavior and any alternative-hotkey handling are clearly established.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.