Comfy-Org / Comfy-Org/ComfyUI_frontend

Track migration of grandfathered comfyPage.setup() suppression comments (internal id evfail-23)

Open Beginner friendly
#16,859 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

**Problem** — #16733 introduced the `comfy/no-comfy-page-setup-call` oxlint rule. The 72 pre-existing `comfyPage.setup()` call sites under `browser_tests/tests/` are grandfathered via `// oxlint-disable-next-line comfy/no-comfy-page-setup-call -- pre-existing call, tracked by evfail-23; not fixed in this pass`. `evfail-23` is an internal tracker id that an upstream contributor cannot resolve, so the migration follow-up is not discoverable from the repo itself. Raised in [the review on #16733](https://github.com/Comfy-Org/ComfyUI_frontend/pull/16733#pullrequestreview-5097989345).

**Goal** — every suppression comment cites a resolvable, in-repo anchor, and the grandfathered calls eventually migrate to zero suppressions.

**Proposed solution** — use this issue as the anchor. A follow-up PR rewrites the suppression comments to cite this issue (e.g. `migration tracked in #`) in place of `evfail-23`.

**Acceptance criteria**
- [ ] All 72 suppression comments point at this issue instead of `evfail-23`
- [ ] `rg 'evfail-23' browser_tests` returns no hits
- [ ] Lint passes with the `.oxlintrc.json` override still in place

Contributor guide

Open the contributing guide

Research direction

Search browser_tests/tests/ for the 72 comfyPage.setup() suppression comments and inspect their current evfail-23 anchors. Replace those anchors with this issue, then run rg 'evfail-23' browser_tests and the repository lint command to verify zero hits and a passing lint check with the .oxlintrc.json override intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.