Comfy-Org / Comfy-Org/ComfyUI_frontend

test: followerDoc malformed-update test couples to Yjs error text

Open
#16,723 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

Nit from reviewing #16664 (filed as an issue per the agreed nit rule, not a PR block).

`src/workbench/extensions/agent/crdt/followerDoc.test.ts:30` asserts `.toThrow('Unexpected end of array')`, the exact message from Yjs internals. A Yjs bump that rewords the error reddens the test without any behavior change.

Suggested: assert `toThrow()` (or a `FollowerApplyError` type) and keep the behavioral checks (no `update` event, `updatesApplied` unchanged).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.