Comfy-Org / Comfy-Org/ComfyUI_frontend

fix(assets): make Cloud flag-off isolation pass

Open
#16,380 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
Dominant language
TypeScript
Stars
2k
Forks
704
Avg merge
1d 8h
Merged PRs (30d)
512

Description

The Cloud Assets flag-off isolation case in PR #16258 now executes under `test.fail`. It remains expected-failing because `assetsEnabled` currently treats Cloud as unconditionally enabled instead of honoring `assets: false`.

Acceptance criteria:
- Cloud honors `assets: false` during setup.
- The existing test passes while asserting zero `GET /api/assets` list requests, a history-backed output card, and no Cloud-only filter control.
- Remove `test.fail` and keep CI green.

Evidence: https://github.com/Comfy-Org/ComfyUI_frontend/pull/16258/files

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.