Comfy-Org / Comfy-Org/ComfyUI_frontend

[test-recorder] record and transform --output can silently overwrite existing spec files

Open
#15,841 0 comments 0 reactions 1 assignee Claimed by @mattmillerai View on GitHub
area:testing Bug Potential Bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Problem
Two paths can silently overwrite existing files:

- `src/commands/record.ts:659-679,759-763` — reusing an existing test name/slug writes directly over `browser_tests/tests/.spec.ts` without checking whether the file exists.
- `src/commands/transform.ts:47-57` — `transform --output` overwrites any existing writable file (a typo can clobber an unrelated committed spec).

### Suggested fix
Refuse existing destinations by default; require explicit confirmation (interactive) or `--force` (non-interactive), or auto-uniquify the name.

_Line references are against branch `cb/comfy-test-usability` (PR #15837); adjust after merge._

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.