Comfy-Org / Comfy-Org/ComfyUI_frontend

vueNodes: error, bypass, mute and executing state are unpainted in simplified mode

Open
#15,317 1 comment 1 reaction 1 assignee Claimed by @benjcooley View on GitHub
area:nodes area:vue-migration Potential Bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

Below the LOD threshold, node state that the user needs is drawn by neither renderer. `drawNode` still returns early under `vueNodesMode` before the state painting, and the box overlay carries only bounds and colour.

## What is missing

Selection is now partially handled, but error, bypass, mute and executing state are not painted at all while simplified. So on a large graph zoomed out, which is exactly when you are looking for an errored or running node, nothing marks it.

This is the case the LOD mode exists to serve: navigating a 3000-node graph. Position and colour alone are a weak vocabulary for that.

## Suggested shape

Extend the box payload beyond `{ bounds, color }` to carry the state flags, and paint them as outline treatments the way the classic renderer does at the same zoom. `nodeStyleUtils.ts` added in #15031 is the natural home for deriving the colours.

Related: #15287 covers the same gap from the minimap side.

## Affected area

- `src/renderer/core/canvas/nodeBoxRenderer.ts`
- `src/renderer/extensions/vueNodes/components/NodeBoxOverlay.vue`
- `src/components/graph/GraphCanvas.vue` (`getNodeBoxes` payload)

Found during review of #15031.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.