Comfy-Org / Comfy-Org/ComfyUI_frontend
Move error classification/absorption modules out of the components tree
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 704
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 512
Description
## Problem
The absorption/classification modules introduced by #14440 are pure domain logic but live under `src/components/rightSidePanel/errors/`:
- `missingResourceAbsorption.ts` (matching policy)
- `errorSeverityClassification.ts` (aggregation)
- `useErrorClassification.ts` (reactive wrapper)
`executionErrorStore` now imports the matcher from the components tree for its retirement watcher — a store depending on a components path (precedent exists via `appModeStore`, but the direction is inverted). The panel folder name also under-sells the consumers: the run button, tab icon, and error overlay all classify through it.
## Suggested move
Relocate the three modules (and their tests/fixtures) to a domain layer — e.g. `src/core/errors/` or `src/platform/errors/` — leaving the presentation-only `useErrorGroups`/components in place. Mechanical, but deferred out of #14440 to keep that diff reviewable.
Contributor guide
Research direction
Start with src/components/rightSidePanel/errors/missingResourceAbsorption.ts, errorSeverityClassification.ts, and useErrorClassification.ts, then trace their tests and fixtures and the executionErrorStore import. Move the domain modules and related tests/fixtures to a suitable errors layer while leaving useErrorGroups and presentation components in place; update consumers so tests still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100