Comfy-Org / Comfy-Org/ComfyUI_frontend
test job fails on ErrorGroupList.test.ts teardown rejection while all 14511 tests pass
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
The `test` job can fail while every test passes.
Observed on [run 30763861095](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/30763861095/job/91539067938) (PR #14484):
```
Test Files 1079 passed (1079)
Tests 14511 passed | 8 skipped (14519)
Errors 2 errors
##[error]Process completed with exit code 1
```
Both errors are the same unhandled rejection:
```
EnvironmentTeardownError: [vitest-worker]: Closing rpc while "onUserConsoleLog" was pending
This error originated in "src/components/rightSidePanel/errors/ErrorGroupList.test.ts"
```
Vitest fails the run on unhandled errors even when no assertion failed, so this reads as a red `test` check on an unrelated PR and costs a re-run to clear. The message points at a `console.*` call still in flight when the worker's rpc closes — something in that file (or a component it mounts) logs after the test that triggered it has finished, most likely from a floating promise or an unawaited timer.
Worth fixing at the source rather than muting: the same shape will recur on any suite that logs from an unawaited path, and "all tests passed but the job is red" trains people to re-run without reading.
Contributor guide
Research direction
Start with src/components/rightSidePanel/errors/ErrorGroupList.test.ts and reproduce the test-job failure described in run 30763861095, watching for logs that remain pending during teardown. Trace the mounted component or test path responsible for the unhandled rejection. Done means the full test job completes without EnvironmentTeardownError while preserving the existing passing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100