Comfy-Org / Comfy-Org/ComfyUI_frontend
Job Queue insertion spec creates waitForResponse before the action that can throw
Open
area:queue
area:testing
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
`assetsVerificationResponse` is created before `addOutputToCurrentWorkflow` (correct, no race) but is first awaited inside `expectNoErrorUiAfterVerification` several statements later.
If `addOutputToCurrentWorkflow` or the node-count poll throws, the promise is never awaited and rejects after the test has already failed, producing unhandled-rejection or teardown noise that obscures the real failure.
Not a correctness hole, a diagnosability one.
`browser_tests/tests/queue/jobOutputInsertion.spec.ts`
---
Surfaced during multi-agent review of #14081 but triaged out of the posted review as non-blocking. Filing so it is not lost.
Contributor guide
Assessment
This issue has not been assessed yet.