Comfy-Org / Comfy-Org/ComfyUI_frontend

CI gap: workspace packages with a typecheck script aren't typechecked in CI

Open
#14,291 1 comment 1 reaction 0 assignees View on GitHub
area:CI/CD
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

Several packages under \`packages/\` define their own \`typecheck\` script (\`tsc --noEmit\`), but nothing in CI invokes it. The root \`pnpm typecheck\` script runs \`vue-tsc --noEmit\`, scoped to the main app — it does not fan out to each workspace package's own typecheck script.

## Affected packages

- \`packages/design-system\` (added its own CI-scoped check in #14080, but repo-wide this is still unaddressed for the others)
- \`packages/tailwind-utils\`
- \`packages/shared-frontend-utils\`
- \`packages/object-info-parser\`

## Proposed fix

Either:
1. Add a single CI job that runs \`pnpm -r typecheck\` (or loops over packages with a \`typecheck\` script) so all of them are covered consistently, or
2. Add per-package path-scoped CI workflows similar to \`ci-design-system-pack.yaml\`.

Option 1 is likely simpler and avoids workflow-file sprawl.

Contributor guide

Open the contributing guide

Research direction

Inspect the typecheck scripts in packages/design-system, packages/tailwind-utils, packages/shared-frontend-utils, and packages/object-info-parser, then review the existing ci-design-system-pack.yaml workflow and root pnpm typecheck script. Run the current checks to confirm the workspace packages are omitted. Done means CI consistently typechecks every workspace package that defines a typecheck script.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.