Comfy-Org / Comfy-Org/ComfyUI_frontend

SubGraph navigation gets stuck in complex workflow after update

Open
#12,845 2 comments 1 reaction 0 assignees View on GitHub
area:subgraph Custom Node Potential Bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Prerequisites

- [x] I am running the latest version of ComfyUI
- [x] I have custom nodes enabled

### What happened?

Hello,

I would like to report a possible frontend regression related to SubGraph navigation.

After updating ComfyUI, I encountered an issue where I can enter a SubGraph, but cannot return to the main workflow. In the same affected workflow, I also cannot navigate into lower-level SubGraphs from inside another SubGraph.

I tested SubGraph navigation with a new empty workflow and a simple dummy SubGraph, and it works normally. Therefore, SubGraphs themselves do not appear to be completely broken. The issue seems to occur only with a more complex workflow.

Observed behavior:

* Simple dummy SubGraph in an empty workflow works correctly.
* In the affected workflow, after entering a ControlNet-related SubGraph, the UI gets stuck.
* I cannot return to the main workflow.
* I cannot navigate into lower-level SubGraphs.
* This started happening after a ComfyUI update.

Expected behavior:

* I should be able to enter and exit SubGraphs normally.
* Nested SubGraph navigation should not lock the UI state.

The affected workflow contains multiple SubGraphs and custom nodes, including ControlNet-related nodes, Advanced ControlNet nodes, MediaPreview nodes, Conditioning Switchers, and other custom nodes.

Environment:

* Environment: RunPod / Linux
* Browser: iPad Safari
* ComfyUI version: [insert version or commit hash]
* ComfyUI frontend version: [insert version if available]

Relevant custom nodes:

* comfyui-advanced-controlnet
* rgthree-comfy
* ComfyUI_Comfyroll_CustomNodes
* comfyui_controlnet_aux
* ComfyUI-MediaPreview
* WAS Node Suite
* JPS Nodes

I can attach the affected workflow JSON for reproduction.

Thank you.

### Steps to Reproduce

[sa_master_0004.json](https://github.com/user-attachments/files/28938878/sa_master_0004.json)

2.
3.

### How is this affecting you?

Crashes ComfyUI completely

### ComfyUI Frontend Version

## System Info OS: linux Python Version: 3.11.10 (main, Sep 7 2024, 18:35:41) [GCC 11.4.0] Embedded Python: false Pytorch Version: 2.4.1+cu124 Arguments: main.py --listen 0.0.0.0 --port 8188 --enable-manager RAM Total: 503.51 GB RAM Free: 477.93 GB Templates Version: 0.9.98 ## Devices - cuda:0 NVIDIA A40 : cudaMallocAsync (cuda) VRAM Total: 44.43 GB VRAM Free: 44.17 GB Torch VRAM Total: 0 B Torch VRAM Free: 0 B

### Browser

Chrome/Chromium

### Console Errors

```javascript
## System Info
OS: linux
Python Version: 3.11.10 (main, Sep 7 2024, 18:35:41) [GCC 11.4.0]
Embedded Python: false
Pytorch Version: 2.4.1+cu124
Arguments: main.py --listen 0.0.0.0 --port 8188 --enable-manager
RAM Total: 503.51 GB
RAM Free: 477.93 GB
Templates Version: 0.9.98

## Devices
- cuda:0 NVIDIA A40 : cudaMallocAsync (cuda)
VRAM Total: 44.43 GB
VRAM Free: 44.17 GB
Torch VRAM Total: 0 B
Torch VRAM Free: 0 B
```

### Logs

```shell

```

### Additional Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.