Comfy-Org / Comfy-Org/ComfyUI_frontend

On Nodes 2 submenus ignore the return value of true to keep open

Open
#12,558 1 comment 0 reactions 0 assignees View on GitHub
area:context-menus Custom Node Potential Bug
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

### Prerequisites

- [x] I am running the latest version of ComfyUI
- [x] I have custom nodes enabled

### What happened?

In Nodes 1, if a submenu callback returned true, the menu remained open.

This does not seem to be the case in Nodes 2.0

### Steps to Reproduce

1. Create a menu item with has_submenu : true
2. Let the callback for that submenu return a value of true
3. Select an entry in the submenu.
The whole menu closes.

### How is this affecting you?

Minor inconvenience

### ComfyUI Frontend Version

1.44.19

### Browser

Chrome/Chromium

### Console Errors

```javascript
None
```

### Logs

```shell

```

### Additional Context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.