Comfy-Org / Comfy-Org/ComfyUI_frontend

refactor: migrate remaining PrimeVue Tag usages in NodeSearchItem.vue to custom Tag component

Open
#11,922 0 comments 0 reactions 1 assignee Claimed by @christian-byrne View on GitHub
area:search developer experience PrimeVue
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

In PR #10673, `NodeSearchItem.vue` aliased the custom Tag component as `ChipTag` to avoid a naming collision with the already-imported PrimeVue `Tag`. This was a deliberate, short-term workaround while the remaining PrimeVue `Tag` usages in the same file had not yet been migrated.

## Follow-up task

Once the remaining PrimeVue `Tag` usages in `NodeSearchItem.vue` are ready to be migrated to the custom component:

1. Replace all `primevue/tag` imports in `NodeSearchItem.vue` with the custom `@/components/chip/Tag.vue`
2. Flip the import alias convention to match the rest of the codebase: import the custom Tag as `Tag` (natural name) and the PrimeVue Tag, if still needed temporarily, as `PrimeTag`
3. Verify all tag/chip usages in `NodeSearchItem.vue` render correctly after migration
4. Check whether any other files still mix both import sources under mismatched aliases and align them

## Context

- Related PR: #10673 (migrate PrimeVue Chip → custom Tag)
- Discussion: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10673#discussion_r3179658413
- Requested by: @christian-byrne

## Acceptance criteria

- [ ] `NodeSearchItem.vue` imports the custom Tag as `Tag` (not `ChipTag`)
- [ ] No remaining `primevue/tag` imports in `NodeSearchItem.vue`
- [ ] All tag/chip badges in `NodeSearchItem.vue` visually match the previous behaviour
- [ ] E2E and unit tests pass

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-11922-refactor-migrate-remaining-PrimeVue-Tag-usages-in-NodeSearchItem-vue-to-custom-Tag-c-3566d73d365081bc97e3c731cc59b0de) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.