Comfy-Org / Comfy-Org/ComfyUI_frontend

fix(e2e): investigate & re-enable fixme test for tag suggestion click in publish dialog

Open
#11,548 0 comments 0 reactions 1 assignee Claimed by @dante01yoon View on GitHub
area:testing
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Follow-up from PR #10770

A `test.fixme` was left in `browser_tests/tests/dialogs/publishDialog.spec.ts` (line 140) during the publish flow E2E test additions. The test currently cannot pass reliably and needs investigation.

### Skipped test

```typescript
// TODO: Tag click emits update:tags but the tag does not appear in the
// active list during E2E. Needs investigation of the parent state binding.
test.fixme('clicking a tag suggestion adds it', async () => {
await dialog.root.getByText('anime').click()

const activeTags = dialog.describeStep.getByRole('list').first()
await expect(activeTags.getByText('anime')).toBeVisible()
})
```

### Root cause hypothesis

Clicking a tag suggestion emits `update:tags`, but the tag does not appear in the active tags list during E2E. This is likely a parent component state binding issue that needs further investigation.

### Acceptance criteria

- [ ] Investigate why the emitted `update:tags` event does not reflect in the active tag list during E2E.
- [ ] Fix the underlying state binding issue (or update the test approach if the issue is purely in the test fixture).
- [ ] Replace `test.fixme` with an active assertion once the fix is confirmed stable.

### References

- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10770
- Review comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10770#discussion_r3048409476
- Requested by: @pythongosssss

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-11548-fix-e2e-investigate-re-enable-fixme-test-for-tag-suggestion-click-in-publish-dial-34a6d73d3650811d8533f09d008b871e) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.