Comfy-Org / Comfy-Org/ComfyUI_frontend

Create a Page Object for the SelectionToolbox in browser tests

Open
#11,244 0 comments 0 reactions 1 assignee Claimed by @dante01yoon View on GitHub
area:testing developer experience
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

The `SelectionToolbox` component currently lacks a dedicated Playwright Page Object in the browser test suite. Tests in `browser_tests/tests/selectionToolboxMoreActions.spec.ts` (and related specs) interact with the toolbox via raw locators (e.g., `.selection-toolbox` class selectors and `getByTestId` calls scattered throughout the spec files).

A dedicated Page Object (e.g., `SelectionToolboxPage` or similar, under `browser_tests/fixtures/`) would:
- Encapsulate all locator logic for the toolbox and its buttons (more-options button, refresh button, bypass button, etc.)
- Provide typed helper methods for common actions (open more options, click pin/unpin, align, distribute, etc.)
- Improve maintainability and readability across all toolbox-related specs

## Requested by

Requested by @DrJKL in PR #10968 (comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10968#discussion_r3075918232).

## References

- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10968

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-11244-Create-a-Page-Object-for-the-SelectionToolbox-in-browser-tests-3426d73d3650812a8819cde7f182e81b) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.