Comfy-Org / Comfy-Org/ComfyUI_frontend

feat: enable additional eslint-plugin-playwright rules

Open
#11,145 0 comments 0 reactions 0 assignees View on GitHub
area:testing enhancement
Dominant language
TypeScript
Stars
2k
Forks
699
Avg merge
1d 7h
Merged PRs (30d)
490

Description

## Summary

Follow-up to the recommended rules enablement in drjkl/playwright-linting. There are additional eslint-plugin-playwright rules worth enabling.

## Priority 1: `no-force-option` (recommended, currently off)

Already in the recommended set but explicitly disabled due to existing violations. Needs a dedicated PR to fix all `{ force: true }` usages.

## Priority 2: Auto-fixable style rules

All three are auto-fixable and improve assertion clarity:

- **`prefer-comparison-matcher`** — Use `toBeGreaterThan()` etc. instead of manual comparisons
- **`prefer-to-be`** — Use `toBe()` instead of `toEqual()` for primitives
- **`prefer-to-contain`** — Use `toContain()` instead of `includes()` checks

Could be a single PR with `--fix`.

## Priority 3: Evaluate

- **`no-slowed-test`** — Disallows `.slow()` annotation. Evaluate violation count before deciding.

## Not recommended

- `no-raw-locators` — too restrictive for this codebase
- `no-hooks` — hooks are heavily used and appropriate
- `max-expects` — needs tuning, likely too restrictive
- `no-get-by-title`, `no-restricted-locators`, `no-restricted-roles` — niche/low value

## Note on oxlint JS plugin OOM

When many browser_tests files are staged, oxlint's alpha JS plugin can OOM in lint-staged (`Insufficient memory to create fixed-size allocator pool`). This is a pre-existing issue unrelated to which rules are enabled.

┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-11145-feat-enable-additional-eslint-plugin-playwright-rules-33e6d73d365081c795eef15d0db1d64e) by [Unito](https://www.unito.io)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.