Comfy-Org / Comfy-Org/ComfyUI_frontend
refactor: move setupSettings into SettingsHelper
- Dominant language
- TypeScript
- Stars
- 2k
- Forks
- 699
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 490
Description
## Summary
Tests in `browser_tests/tests/resultGallery.spec.ts` (and likely other test files) call `comfyPage.settings.setSetting()` multiple times in a `beforeEach` block to configure required settings. This pattern should be encapsulated into a dedicated `setupSettings` method on the `SettingsHelper` class so tests can invoke it in a single, readable call.
## Motivation
- Reduces boilerplate in test `beforeEach` hooks
- Centralises common setting configurations, making them easier to maintain
- Improves readability and consistency across the test suite
## References
- PR: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10134
- Comment: https://github.com/Comfy-Org/ComfyUI_frontend/pull/10134#discussion_r2950107456
/cc @DrJKL
┆Issue is synchronized with this [Notion page](https://www.notion.so/Issue-10223-refactor-move-setupSettings-into-SettingsHelper-3266d73d3650812fbe0bc919a94215fa) by [Unito](https://www.unito.io)
Contributor guide
Assessment
This issue has not been assessed yet.