Change KSampler add_noise type to BOOLEAN (improvement)
- Dominant language
- Python
- Stars
- 133k
- Forks
- 15.7k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 155
Description
KSampler Advanced has an `add_noise` field whose value is either `enable` or `disable`. However, it's neither a boolean nor a string, making it harder to control outside of the node itself.
Considering it doesn't have any reason not to be a boolean I think it should be changed to the proper native type. Same goes for `return_with_leftover_noise` or any other field: do not use a custom data type if a native type is enough.
Contributor guide
Research direction
Locate the KSampler Advanced node definition and inspect how its add_noise and return_with_leftover_noise fields are declared and consumed. Check the surrounding node input schema and call sites first; done means these fields use native boolean values while preserving their existing behavior, with any additional custom types considered separately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai, backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100