Comfy-Org / Comfy-Org/ComfyUI

Beta nodes "Cond Pair Set Props" and "Cond Pair Set Props Combine" seem to interpret mask as if they were inverted

Open
#8,993 1 comment 0 reactions 1 assignee Assigned to @Kosinkadink View on GitHub
bug-cop:triaged Potential Bug
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 10h
Merged PRs (30d)
153

Description

### Custom Node Testing

- [x] I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help)

### Expected Behavior

Using "Cond Pair Set Props" and "Cond Pair Set Props Combine" nodes, I would expect the "mask" property on both to use high mask values to define the affected area, as usual.

### Actual Behavior

"Cond Pair Set Props" and "Cond Pair Set Props Combine" seem to use their masks values in a inverted way, affecting everything except the masked area.

Workaround is invert each mask

### Steps to Reproduce

Use "Cond Pair Set Props" and "Cond Pair Set Props Combine" with complementary masks.
Use "Create Hook Lora" as input to "Cond Pair Set Props" - use a LoRA with obvious effects, put at high strength.

### Debug Logs

```powershell
Don't have them on hand.
```

### Other

Sorry for not dropping a workflow, I thought you'd want to know this happens.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.