Run on Change behaving erratically
- Dominant language
- Python
- Stars
- 133k
- Forks
- 15.7k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 155
Description
### Expected Behavior
After clicking "Run on Change", upon change of a parameter (either by entering a new value, or increasing / decreasing value with arrows), new generation should be added to queue: increase of queue number + generation
### Actual Behavior
Queue number hardly ever changes, some generations are queued, some are not.
I'm running a list of prompts in sequence, so increasing index 1 at a time should queue each prompt on the list.
But only some are actually generated, without logic - maybe if I run index from 1 to 10, only 1, 4, 5 and 9 have been generated.
### Steps to Reproduce
1. Click "Run on Change"
2. Increase number of steps from 10 to 14 by increment of 1 using right arrow
3. only some generations are produced (in my test, 11 and 14)
[Basic SDXL TXT2IMG Workflow.json](https://github.com/user-attachments/files/20126956/Basic.SDXL.TXT2IMG.Workflow.json)
### Debug Logs
```powershell
Adding extra search path checkpoints D:\stable-diffusion-webui\models\Stable-diffusion
Adding extra search path configs D:\stable-diffusion-webui\models\Stable-diffusion
Adding extra search path vae D:\stable-diffusion-webui\models\VAE
Adding extra search path loras D:\stable-diffusion-webui\models\Lora
Adding extra search path loras D:\stable-diffusion-webui\models\LyCORIS
Adding extra search path upscale_models D:\stable-diffusion-webui\models\ESRGAN
Adding extra search path upscale_models D:\stable-diffusion-webui\models\RealESRGAN
Adding extra search path upscale_models D:\stable-diffusion-webui\models\SwinIR
Adding extra search path embeddings D:\stable-diffusion-webui\embeddings
Adding extra search path hypernetworks D:\stable-diffusion-webui\models\hypernetworks
Adding extra search path controlnet D:\stable-diffusion-webui\models\ControlNet
[START] Security scan
[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2025-05-09 20:21:56.043
** Platform: Windows
** Python version: 3.12.7 (tags/v3.12.7:0b05ead, Oct 1 2024, 03:06:41) [MSC v.1941 64 bit (AMD64)]
** Python executable: D:\ComfyUI\python_embeded\python.exe
** ComfyUI Path: D:\ComfyUI\ComfyUI
** ComfyUI Base Folder Path: D:\ComfyUI\ComfyUI
** User directory: D:\ComfyUI\ComfyUI\user
** ComfyUI-Manager config path: D:\ComfyUI\ComfyUI\user\default\ComfyUI-Manager\config.ini
** Log path: D:\ComfyUI\ComfyUI\user\comfyui.log
Prestartup times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\rgthree-comfy
1.9 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
Checkpoint files will always be loaded safely.
Total VRAM 16376 MB, total RAM 32492 MB
pytorch version: 2.5.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 4090 Laptop GPU : cudaMallocAsync
Using pytorch attention
Python version: 3.12.7 (tags/v3.12.7:0b05ead, Oct 1 2024, 03:06:41) [MSC v.1941 64 bit (AMD64)]
ComfyUI version: 0.3.33
ComfyUI frontend version: 1.18.9
[Prompt Server] web root: D:\ComfyUI\python_embeded\Lib\site-packages\comfyui_frontend_package\static
D:\ComfyUI\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
@torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingSingleImageEffectInput has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingDualCharacterEffectInput has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingImageGenerationsRequest has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingVirtualTryOnRequest has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingText2VideoRequest has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
D:\ComfyUI\python_embeded\Lib\site-packages\pydantic\_internal\_fields.py:132: UserWarning: Field "model_name" in KlingImage2VideoRequest has conflict with protected namespace "model_".
You may be able to resolve this warning by setting `model_config['protected_namespaces'] = ()`.
warnings.warn(
Note: NumExpr detected 32 cores but "NUMEXPR_MAX_THREADS" not set, so enforcing safe limit of 16.
NumExpr defaulting to 16 threads.
[Crystools INFO] Crystools version: 1.22.1
[Crystools INFO] CPU: Intel(R) Core(TM) i9-14900HX - Arch: AMD64 - OS: Windows 11
[Crystools INFO] Pynvml (Nvidia) initialized.
[Crystools INFO] GPU/s:
[Crystools INFO] 0) NVIDIA GeForce RTX 4090 Laptop GPU
[Crystools INFO] NVIDIA Driver: 560.94
ComfyUI-GGUF: Partial torch compile only, consider updating pytorch
### Loading: ComfyUI-Manager (V3.31.13)
[ComfyUI-Manager] network_mode: public
### ComfyUI Version: v0.3.33-4-g42da2747 | Released on '2025-05-09'
[rgthree-comfy] Loaded 42 epic nodes. π
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.
WAS Node Suite: Finished. Loaded 220 nodes successfully.
"Every strike brings me closer to the next home run." - Babe Ruth
Import times for custom nodes:
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\websocket_image_save.py
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\comfy-image-saver
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-GGUF
0.0 seconds: D:\ComfyUI\ComfyUI\custom_nodes\rgthree-comfy
0.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_UNet_bitsandbytes_NF4
0.6 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.7 seconds: D:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Crystools
2.1 seconds: D:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui
Starting server
To see the GUI go to: http://127.0.0.1:8188
FETCH ComfyRegistry Data: 5/84
FETCH ComfyRegistry Data: 10/84
FETCH ComfyRegistry Data: 15/84
FETCH ComfyRegistry Data: 20/84
FETCH ComfyRegistry Data: 25/84
FETCH ComfyRegistry Data: 30/84
FETCH ComfyRegistry Data: 35/84
FETCH ComfyRegistry Data: 40/84
FETCH ComfyRegistry Data: 45/84
FETCH ComfyRegistry Data: 50/84
FETCH ComfyRegistry Data: 55/84
FETCH ComfyRegistry Data: 60/84
FETCH ComfyRegistry Data: 65/84
FETCH ComfyRegistry Data: 70/84
FETCH ComfyRegistry Data: 75/84
FETCH ComfyRegistry Data: 80/84
FETCH ComfyRegistry Data [DONE]
[ComfyUI-Manager] default cache updated: https://api.comfy.org/nodes
FETCH DATA from: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json [DONE]
[ComfyUI-Manager] All startup tasks have been completed.
got prompt
model weight dtype torch.float16, manual cast: None
model_type EPS
Using pytorch attention in VAE
Using pytorch attention in VAE
VAE load device: cuda:0, offload device: cpu, dtype: torch.bfloat16
Requested to load SDXLClipModel
loaded completely 9.5367431640625e+25 1560.802734375 True
CLIP/text encoder model load device: cuda:0, offload device: cpu, current: cuda:0, dtype: torch.float16
Requested to load SDXL
loaded completely 12001.872212219238 4897.0483474731445 True
100%|ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ| 11/11 [00:04<00:00, 2.48it/s]
Requested to load AutoencoderKL
loaded completely 3559.9759979248047 159.55708122253418 True
Prompt executed in 17.79 seconds
got prompt
100%|ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ| 14/14 [00:04<00:00, 2.80it/s]
Prompt executed in 5.86 seconds
```
### Other
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.