Comfy-Org / Comfy-Org/ComfyUI

spandrel python package pulls nvidia dependencies even on AMD systems, and since it's in requirements.txt it gets auto installed during updates

Open
#4,878 1 comment 0 reactions 0 assignees View on GitHub
AMD Potential Bug
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 6h
Merged PRs (30d)
155

Description

### Expected Behavior

Updating ComfyUI does not install nvidia dependencies on AMD systems

### Actual Behavior

Updating ComfyUI installs nvidia dependencies on AMD systems

### Steps to Reproduce

source venv/bin/activate
pip install -r requirements.txt

### Debug Logs

```powershell
Don't have them anymore and I don't want to install those deps again but out of other things:

nccl-cu12 nvidia-cuda-cupti-cu12 nvidia-cuda-nvrtc-cu12 nvidia-cuda-runtime-cu12 nvidia-cudnn-cu12 nvidia-cufft-cu12 nvidia-curand-cu12 nvidia-cusolver-cu12 nvidia-cusparse-cu12 nvidia-nccl-cu12 nvidia-nvjitlink-cu12 nvidia-nvtx-cu12

get installed
```

### Other

I suggest not putting spandrel as a default dependency until it doesn't pull nvidia deps on all platforms

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.