Comfy-Org / Comfy-Org/ComfyUI

Specifying incorrect type in custom node doens't report error

Open
#33 2 comments 0 reactions 0 assignees View on GitHub
User Support
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 10h
Merged PRs (30d)
153

Description

Consider
```python
class ConstFloat:
@classmethod
def INPUT_TYPES(s):
return {"required": { "n": ("FlOAT", {"default": 1.0, "min": -512.0, "max": 512.0})}}
RETURN_TYPES = ("FLOAT",)
FUNCTION = "test"
CATEGORY = "Example"
def test(self, n):
return (n,)

NODE_CLASS_MAPPINGS = {
"ConstFloat": ConstFloat
}
```
Right now I can add it to the graph normally:

![image](https://user-images.githubusercontent.com/13607441/222156589-a47bf8ee-2124-4a27-bb2f-b0a3bb24a5c7.png)

There is no indication in the console or browser UI that something is wrong:
```text
Set vram state to: NORMAL VRAM
Using sub quadratic optimization for cross attention, if you have memory or speed issues try using: --use-split-cross-attention
No module 'xformers'. Proceeding without it.
Starting server

To see the GUI go to: http://127.0.0.1:8188
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.