Comfy-Org / Comfy-Org/ComfyUI

Found a serious bug in packing "CLIP Text Encode" node into group.

Open
#3,142 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 6h
Merged PRs (30d)
155

Description

![uqUvk8qloh](https://github.com/comfyanonymous/ComfyUI/assets/3765653/e9f54305-db2e-4cf8-b2b2-1dbdbaafac93)
![qznCIoLqVW](https://github.com/comfyanonymous/ComfyUI/assets/3765653/d8ba9876-a943-414d-bdd8-0aa02e905a6d)
![VkkhzNxGog](https://github.com/comfyanonymous/ComfyUI/assets/3765653/a4b7fd68-cdd3-44c3-b778-4ec26fcbafdf)

When packing multiple "CLIP Text Encode" nodes into a node group, if one of the text widgets is converted to input, it will cause CLIP to get confused. If you pack a Reroute node into a node group at the same time, you may even find that the connection is missing when you dissolve the node group.

When the prompts are slightly more complex, this can lead to completely unpredictable results.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.