Comfy-Org / Comfy-Org/ComfyUI

Potential error in `comfy/model_detection.py`

Open
#2,917 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

In function `convert_config`, there is a code snippet:

```python
if "attention_resolutions" in new_config:
attention_resolutions = new_config.pop("attention_resolutions")
transformer_depth = new_config.get("transformer_depth", None)
transformer_depth_middle = new_config.get("transformer_depth_middle", None)

if isinstance(transformer_depth, int):
transformer_depth = len(channel_mult) * [transformer_depth]
if transformer_depth_middle is None:
transformer_depth_middle = transformer_depth[-1]
```

If both `transformer_depth` and `transformer_depth_middle` are set to `None`, `transformer_depth[-1]` will be accessed, which is invalid as `transformer_depth` is `None`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.