Comfy-Org / Comfy-Org/ComfyUI

Server storage related code shouldn't be named "app"

Open
#2,584 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

Just a quick bug report. The current server-side storage uses code from a folder called `app`. The import for it in `server.py` is `from app.user_manager import UserManager`.

The issue with this is that a lot of ML projects already install as generic names such as "app" or "library", meaning it's possible to have a conflict between a system level package and the local file. This will cause an import error in most cases.

The easiest solution - in my opinion - is to simply give it a more descriptive name.

Here is an example of running the latest commit in a conda env that is shared between comfy and [audiocraft](https://github.com/facebookresearch/audiocraft) installed via `pip install -e .`

![image](https://github.com/comfyanonymous/ComfyUI/assets/125218114/29a10a5a-2bbe-435e-8a34-8c7a9b8f257f)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.