Comfy-Org / Comfy-Org/ComfyUI

Settings values are ignored on refresh.

Open
#2,547 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

Specifically, logging.js _always_ patches console.log on refresh, even when "Logging" is unchecked, though perhaps other settings are also being ignored on refresh if a larger issue.

1. Uncheck "Logging" from the settings dialog.
2. Notice logging.js's `unpatchConsole` is called and console.logs correctly avoid logging.js.
3. Refresh the page.
4. Notice `patchConsole` is called, being fed a "true" for logging, despite Logging being unchecked.
5. Open settings panel and observe "Logging" is still unchecked.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.