Comfy-Org / Comfy-Org/ComfyUI

Please add the node id to progress messages from the WebSockets implementation (also towards parallel execution)

Open
#2,425 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 10h
Merged PRs (30d)
153

Description

In the websockets protocol, progress messages don't contain the node id, which has to be deducted by the previous "executing" message. If parallel execution was enabled, such protocol would not work anymore. So I suggest to add the node id also to the progress messages, so that programs using the WS protocol can be already "future-proofed" and be prepared for parallel execution.

[EDIT]: for similar reasons also an "execution finished" message for nodes would be required (unless 100% progress already means "finished", not sure about that)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.