Comfy-Org / Comfy-Org/ComfyUI

error if the image save path is on diffrent drive

Open
#2,025 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

Hello together,

forst I have to say I love comfyui, great work. Laso the custom nodes.
RESPECT at all who are working for it.

My "problem" is.
I use a custom "image saver node".
If the path is on the same drive as the ComfyUI_windows_portable there is no error message.
If I change the saving path to an diffrent drive, I got an error message.
The image is stored correctly.
For example.
The "ComfyUI_windows_portable" is on drive M: and I use as image saving path E:\images
following will come up in the console window:

`File "M:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\aiohttp\web_protocol.py", line 433, in _handle_request
resp = await request_handler(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "M:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\aiohttp\web_app.py", line 504, in _handle
resp = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "M:\ComfyUI_windows_portable\python_embeded\Lib\site-packages\aiohttp\web_middlewares.py", line 117, in impl
return await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "M:\ComfyUI_windows_portable\ComfyUI\server.py", line 46, in cache_control
response: web.Response = await handler(request)
^^^^^^^^^^^^^^^^^^^^^^
File "M:\ComfyUI_windows_portable\ComfyUI\server.py", line 271, in view_image
if os.path.commonpath((os.path.abspath(full_output_dir), output_dir)) != output_dir:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 826, in commonpath
ValueError: Paths don't have the same drive`

I tried diffrent custom nodes WAS / WLSH all the same error. If I bypass the saver node, no error message comes.

Greetings
michael

P.S. Sorry for my bad english. English ist not my native language.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.