Comfy-Org / Comfy-Org/ComfyUI

List output types broken with recent changes

Open
#1,674 3 comments 0 reactions 0 assignees View on GitHub
User Support
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

Looks like 6fc7314 and then b9b178b changed input widget types in a way that breaks other nodes (changes seemed to only consider the PrimitiveNode, maybe?).

FWIW, a better type system for arrays would be great, but I think consideration needs to be taken to not churn and break nodes with array types already.

The problem currently lies in a Python configured node still outputs array types as a joined list; but the changes in the commits above create a new type for list widgets converted to inputs, which is now not compatible.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.