Comfy-Org / Comfy-Org/ComfyUI

Previous result no longer cached, since PR 15027 (fast-disk doesn't resolve) Also, will old less-aggressive-pinning return as a feature?

Open
#15,556 3 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

Since PR 15027, cache of previous generations seems non-existent.

I was really happy with v28, as linux managed caching perfectly in the 112GB system RAM I allocate (GPU=5090).

I tried --fast-disk, but whilst it stops pinning, it doesn't bring back the caching of generation. That's the one thing I wanted Comfy to pin some space for.

@rattus128 , you wrote "We can make the old way a separate option but its probably best to just consolidate with this and --fast-disk" in the pull.
Is there a chance the old option will return?

Perhaps there's a setting that can achieve this I overlooked?

I can't say I've seen any massive slow-ups since the pinning, and your work with pinning has been a huge benefit in allowing one to smoothly use models beyond one's VRAM - thank you. 15027 seems somewhat without benefit on my spec as yet.
If I flicked between an int8-convrot, a BF16, and finetune in a workflow - linux would cache them all just fine without need for Comfy to take responsibility.

**Steps to reproduce**
1. Generate an image in Krea with one sampler (run)
2. Switch to another sampler (run)
3. Switch back (run).

Run 3 used to generate from cache. Same for changing seeds. Now it doesn't.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing PR 15027 and the behavior of the --fast-disk option, then reproduce the three-step sampler and seed-switching workflow described here. Trace how previous generations are cached or released; done means switching back reuses the prior result as before, while --fast-disk retains its intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
linux, python
Domain
backend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.