Comfy-Org / Comfy-Org/ComfyUI

Issue with Commit fbe6d3c - Add configurable DETAIL logging side channel (#15064)

Open
#15,136 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

I hate to get forced an additional log on me, that automatically writes a file (comfyui_detail.log) into the folder i call comfyui from. Firstly i expect log files written into the user folder inside the comfyui folder, secondly if i have the default log level as INFO, i do not expect an additional DETAIL log i never asked for.
If you implemented this as a feature and think it is useful, at least write the log to the user folder where the standard log resides!
Better yet, make this optional - or best, just roll back to previous functionality that was absolutely fine!!

BTW, using the option --verbose DETAIL comfyui\user\comfyui-detail.log writes an additional DETAIL log into the user folder, not replacing the one written to my script base folder.

Sorry for being pissed, but every other day something breaks or changes without improving things and nobody seems to care (i hope i am completely wrong about that part!).

I will only give more details, if explicitely asked, as the code is self explaining i think, example:

main.py - line 22:
file_log_outputs = [('DETAIL', 'comfyui_detail.log'), *get_file_log_outputs(args.verbose)]
-> hard coded log file!

Contributor guide

Open the contributing guide

Research direction

Inspect main.py around line 22 and trace how the default INFO setting and --verbose DETAIL argument create file outputs. Reproduce both behaviors with the paths shown in the issue; done means the unexpected DETAIL log is no longer created by default and the intended user-folder logging behavior is clear and consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
observability-sre
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.