Comfy-Org / Comfy-Org/ComfyUI

`apply_rotary_pos_emb` method removal without any notice

Open
#14,314 2 comments 1 reaction 0 assignees View on GitHub
Potential Bug
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

### Custom Node Testing

- [ ] I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help)

### Expected Behavior

`comfy.ldm.cosmos.predict2.apply_rotary_pos_emb()` worked well so far

### Actual Behavior

In #14192 `apply_rotary_pos_emb` was removed without any notifications so any nodes using cosmos-predict2 involving anima broke upon 0.24.0

### Steps to Reproduce

`from comfy.ldm.cosmos.predict2 import apply_rotary_pos_emb` in python

### Debug Logs

```powershell
ImportError: cannot import name 'apply_rotary_pos_emb' from 'comfy.ldm.cosmos.predict2' (/home/jovyan/ComfyUI/main/comfy/ldm/cosmos/predict2.py)
```

### Other

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.