Comfy-Org / Comfy-Org/ComfyUI

node_replacements.py needs a node version for multiple corrections

Open
#13,323 0 comments 0 reactions 0 assignees View on GitHub
Feature
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 7h
Merged PRs (30d)
158

Description

### Feature Idea

node_replacements it now a way to correct node and slot names and order.

(I have created my own corrector for this in js, but can not fully emigrate my corrections to node_replacements yet, but i am testing the functions right now.)

To have the possibility to correct a node multiple times, it needs a version number, best as simple float.
Then a "one change after an other" method is possible. (0.0 < 0.1 < 1.0 < ...)
And the correction can be limited if the workflow-node version is smaller then the node_replacements version, and the upgrade happens before the workflow-node version is upgraded to the code-node version number.
(Maybe create a log file of changes for debugging?)

In the Node py code (and saved in the Workflow json):
```
NODE_VERSION = 2.0
```

in node_replacements py code:
```
await api.node_replacement.register(io.NodeReplace(
node_version=2.0,
```

https://docs.comfy.org/custom-nodes/backend/node-replacement

### Existing Solutions

_No response_

### Other

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.