`create_origin_only_middleware` is insufficient guard against DNS rebinding attacks
Open
- Dominant language
- Python
- Stars
- 133k
- Forks
- 15.7k
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 158
Description
The goal of `create_origin_only_middleware` is to prevent other websites from being able to interact with ComfyUI, however this guard is insufficient in the face of a DNS rebinding attack.
https://github.com/Comfy-Org/ComfyUI/blob/06f85e2c792c626f2cab3cb4f94cd30d43e9347b/server.py#L144-L178
See:
- https://huntr.com/bounties/f1458e43-64a7-4df2-b71c-9ca453755dc7
- https://github.com/nccgroup/singularity/blob/master/html/payloads/comfyui.js
Contributor guide
Assessment
This issue has not been assessed yet.