Comfy-Org / Comfy-Org/ComfyUI

make edit error

Open
#12,693 0 comments 0 reactions 0 assignees View on GitHub
Potential Bug
Dominant language
Python
Stars
133k
Forks
15.7k
Avg merge
1d 6h
Merged PRs (30d)
155

Description

### Custom Node Testing

- [x] I have tried disabling custom nodes and the issue persists (see [how to disable custom nodes](https://docs.comfy.org/troubleshooting/custom-node-issues#step-1%3A-test-with-all-custom-nodes-disabled) if you need help)

### Expected Behavior

When the mask output by the mask editor is optional at the mask input of the next node, there is a bug that outputs a default mask of 64*64
example codes:
```
@classmethod
def execute(cls, images,dw,yolo,short_side,mask=None) -> io.NodeOutput:
dw_path=folder_paths.get_full_path("dwpose", dw) if dw != "none" else None
yolo_path=folder_paths.get_full_path("dwpose", yolo) if yolo != "none" else None
from .model_loader_utils import get_pose_normal
images=get_pose_normal(images,os.path.join(folder_paths.base_path,"dwpose"),device,dw_path,yolo_path)
if mask is not None:
images = merge_mask_with_pose(mask, images) # casue error here
```
The screenshot of the node is as follows:

The error reported by the node shown in the diagram is due to the input mask being set to the default size of 64*64

Image

### Actual Behavior

It will appear during the first run, but if it outputs normally once, it will not appear again

### Steps to Reproduce

Occasionally, it is speculated that the issue may arise when the "mask" setting is set to optional and the default value is set to None

### Debug Logs

```powershell
Miss
```

### Other

Occasionally,
it is speculated that the issue may arise when the mask is set as optional and the default value is set to None

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the reported first-run failure with an optional mask whose default is None, using the execute example and the mask editor workflow described in the issue. Trace where the 64*64 default mask is produced and compare it with the image dimensions; done means the optional input no longer causes a size mismatch on the first run.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.